Enable file locking support in illumos #148322
Merged
+16
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
Collaborator
|
rustbot has assigned @Mark-Simulacrum. Use |
Member
Author
|
r? @tgross35 Currently testing this on my illumos VM, will report back once the tests pass. |
Collaborator
|
|
pietroalbini
force-pushed
the
ea-flock-illumos
branch
from
8e95afa to
3a696d6
Compare
Member
Author
|
Ran the tests locally, I can confirm the changes work. |
Member
|
This looks right to me and your tests pass so r=me if CI is happy. |
pietroalbini
force-pushed
the
ea-flock-illumos
branch
from
3a696d6 to
72ee3fd
Compare
This comment was marked as outdated.
This comment was marked as outdated.
rust-bors bot
added a commit
that referenced
this pull request
Oct 31, 2025
Enable file locking support in illumos
This comment has been minimized.
This comment has been minimized.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment has been minimized.
This comment has been minimized.
rust-bors bot
added a commit
that referenced
this pull request
Oct 31, 2025
Enable file locking support in illumos try-job: arm-android
Member
|
I figured we'd land Illumos first since as you said it is tier-2-with-host-tools so cargo has battle-tested this in the past. Then we can separately discuss what to do on Android. I pinged the target maintainers in #148325. |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
pietroalbini
force-pushed
the
ea-flock-illumos
branch
from
72ee3fd to
3d9c69b
Compare
Member
Author
|
Ok, on second thought, let's just focus this PR on the illumos changes. @bors r=ChrisDenton |
Collaborator
bors
removed
the
S-waiting-on-review
This was referenced Oct 31, 2025
bors
added a commit
that referenced
this pull request
Oct 31, 2025
Rollup of 9 pull requests Successful merges: - #139310 (add first HelenOS compilation targets) - #147161 (implement VecDeque extend_from_within and prepend_from_within) - #147622 (`unicode_data` refactors) - #147780 (Implement VecDeque::extract_if) - #147942 (Enable regression labeling aliases) - #147986 (Use fstatat() in DirEntry::metadata on Apple platforms) - #148103 (cg_llvm: Pass `debuginfo_compression` through FFI as an enum) - #148319 (docs: Fix argument names for `carrying_mul_add`) - #148322 (Enable file locking support in illumos) r? `@ghost` `@rustbot` modify labels: rollup
Zalathar
added a commit
to Zalathar/rust
that referenced
this pull request
Nov 1, 2025
…ChrisDenton Enable file locking support in illumos rust-lang#132977 introduced an allow-list of targets supporting file locking, but forgot to add illumos to it (which introduced support for it in ~2015). `File::lock` and friends are now stable, and the ecosystem is slowly replacing custom libc calls with the standard library. Crucially, in 1.91 both Cargo and bootstrap switched to `File::lock`, both breaking build directory locking. This PR enables file locking on illumos. Fixes rust-lang#146312.
Zalathar
added a commit
to Zalathar/rust
that referenced
this pull request
Nov 1, 2025
…ChrisDenton Enable file locking support in illumos rust-lang#132977 introduced an allow-list of targets supporting file locking, but forgot to add illumos to it (which introduced support for it in ~2015). `File::lock` and friends are now stable, and the ecosystem is slowly replacing custom libc calls with the standard library. Crucially, in 1.91 both Cargo and bootstrap switched to `File::lock`, both breaking build directory locking. This PR enables file locking on illumos. Fixes rust-lang#146312.
bors
added a commit
that referenced
this pull request
Nov 1, 2025
Rollup of 9 pull requests Successful merges: - #139310 (add first HelenOS compilation targets) - #147161 (implement VecDeque extend_from_within and prepend_from_within) - #147622 (`unicode_data` refactors) - #147780 (Implement VecDeque::extract_if) - #147942 (Enable regression labeling aliases) - #147986 (Use fstatat() in DirEntry::metadata on Apple platforms) - #148103 (cg_llvm: Pass `debuginfo_compression` through FFI as an enum) - #148319 (docs: Fix argument names for `carrying_mul_add`) - #148322 (Enable file locking support in illumos) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
that referenced
this pull request
Nov 1, 2025
Rollup merge of #148322 - oxidecomputer:ea-flock-illumos, r=ChrisDenton Enable file locking support in illumos #132977 introduced an allow-list of targets supporting file locking, but forgot to add illumos to it (which introduced support for it in ~2015). `File::lock` and friends are now stable, and the ecosystem is slowly replacing custom libc calls with the standard library. Crucially, in 1.91 both Cargo and bootstrap switched to `File::lock`, both breaking build directory locking. This PR enables file locking on illumos. Fixes #146312.
Amanieu
added
beta-accepted
Member
|
Backport accepted. |
Merged
cuviper
removed
the
beta-nominated
bors
added a commit
that referenced
this pull request
Nov 6, 2025
[stable] Prepare Rust 1.91.1 This PR prepares the artifacts for Rust 1.91.1, targeting next Monday with the following backports: * #148322 * #148363 cc `@rust-lang/release`
bors
added a commit
that referenced
this pull request
Nov 7, 2025
[stable] Prepare Rust 1.91.1 This PR prepares the artifacts for Rust 1.91.1, targeting next Monday with the following backports: * #148322 * #148363 cc `@rust-lang/release`
bors
added a commit
that referenced
this pull request
Nov 7, 2025
[stable] Prepare Rust 1.91.1 This PR prepares the artifacts for Rust 1.91.1, targeting next Monday with the following backports: * #148322 * #148363 cc `@rust-lang/release`
cuviper
removed
the
stable-nominated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#132977 introduced an allow-list of targets supporting file locking, but forgot to add illumos to it (which introduced support for it in ~2015).
File::lockand friends are now stable, and the ecosystem is slowly replacing custom libc calls with the standard library. Crucially, in 1.91 both Cargo and bootstrap switched toFile::lock, both breaking build directory locking.This PR enables file locking on illumos. Fixes #146312.